[Lkw] [PATCH] nvme-cmb: add a per-device private data structure

Geremias Baudino geremiasbaudino at mi.unc.edu.ar
Fri Sep 15 14:58:26 EDT 2023


create empty structure, allocate mem in the probe routine and free in the remove routine

Signed-off-by: Geremias Baudino geremiasbaudino at mi.unc.edu.ar
---
 drivers/block/nvme-cmb.c | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/drivers/block/nvme-cmb.c b/drivers/block/nvme-cmb.c
index 01fed1de7..9d893a364 100644
--- a/drivers/block/nvme-cmb.c
+++ b/drivers/block/nvme-cmb.c
@@ -5,33 +5,47 @@
 
 MODULE_LICENSE("GPL");
 
+struct nvme_cmb_dev {
+};
+
 static int nvme_cmb_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 {
+	struct nvme_cmb_dev *dev;
 	int error;
 
 	dev_info(&pdev->dev, "found NVMe device\n");
 
+	dev = kzalloc(sizeof(*dev), GFP_KERNEL);
+	if (!dev)
+		return -ENOMEM;
+
 	pci_set_master(pdev);
 	error = pci_enable_device_mem(pdev);
 	if (error)
-		return error;
+		goto out_free_dev;
 	error = pci_request_mem_regions(pdev, "nvme-cmb");
 	if (error)
 		goto out_disable_device;
 
+	dev_set_drvdata(&pdev->dev, dev);
 	return 0;
 
 out_disable_device:
 	pci_disable_device(pdev);
+out_free_dev:
+	kfree(dev);
 	return error;
 }
 
 static void nvme_cmb_remove(struct pci_dev *pdev)
 {
+	struct nvme_cmb_dev *dev = dev_get_drvdata(&pdev->dev);
+
 	dev_info(&pdev->dev, "unbinding NVMe device\n");
 
 	pci_release_mem_regions(pdev);
 	pci_disable_device(pdev);
+	kfree(dev);
 }
 
 static const struct pci_device_id nvme_cmb_id_table[] = {
-- 
2.39.2




More information about the LKW mailing list